[APIDiff] Enable tests on non-Darwin #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
apple/swift#37703 |
|
apple/swift#37703 |
tomerd
reviewed
May 29, 2021
| guard let tool = try? Resources.default.toolchain.getSwiftAPIDigester() else { | ||
| throw XCTSkip("swift-api-digester unavailable") | ||
| } | ||
| guard localFileSystem.isSymlink(tool) else { |
There was a problem hiding this comment.
this seems odd. no better way to tell? cc @abertelrud
There was a problem hiding this comment.
I agree, this is fairly subtle and won't work in the general case. Is there a -version flag with which it could be invoked and then a more robust check could be made?
There was a problem hiding this comment.
swift-api-digester is part of the frontend now, so unfortunately there's no version number to check for until "Swift Next" gets an official version number
elsh
approved these changes
Jun 17, 2021
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the api diff tests on Linux once apple/swift#37703 is merged
Motivation:
Make sure experimental-api-diff is works and is tested on Linux
Modifications:
This PR just enables tests, the cross-platform fix is in apple/swift#37703
Result:
API diff tests will run on all platforms