[SR-14782] swift package describe is omitting product dependencies from per-target output
#3556
Conversation
…from per-target output While `swift package describe` had an entry for `target_dependencies` in the output of each target, it omitted `product_dependencies`. rdar://79358923
|
@swift-ci please smoke test |
| @@ -254,6 +254,21 @@ final class PackageToolTests: XCTestCase { | |||
| XCTAssert(textChunk6.contains("Path: Sources/CExec"), textChunk6) | |||
| XCTAssert(textChunk6.contains("Sources:\n main.c"), textChunk6) | |||
| } | |||
|
|
|||
| fixture(name: "DependencyResolution/External/Simple/Bar") { prefix in | |||
There was a problem hiding this comment.
This uses an existing test fixture so we don't need to add more of them.
| let targetDependencies = target.dependencies.compactMap{ $0.target } | ||
| self.targetDependencies = targetDependencies.isEmpty ? nil : targetDependencies.map{ $0.name } | ||
| let productDependencies = target.dependencies.compactMap{ $0.product } | ||
| self.productDependencies = productDependencies.isEmpty ? nil : productDependencies.map{ $0.name } |
There was a problem hiding this comment.
cc @yim-lee for potential impact on collection generator
There was a problem hiding this comment.
In theory this should have no impact since it's additive, but that's a good point. I guess this would have the effect of omitting the target_dependencies empty array for a target that had only product dependencies, in addition to adding the product_dependencies array. I don't know if product dependencies is something that you might want to start including in the collections at some point — I don't think that's in the data structures now (are target dependencies there now?).
There was a problem hiding this comment.
👍 thanks.
The generator is not using describe yet (but will), so this change has no impact. I don't think we will include *_dependencies in the package collection data, but IIRC the intention is that it will help determine which targets to include (i.e., only targets included in a product).
There was a problem hiding this comment.
Sounds good. That's in the separate product_memberships array, and unaffected by this.
abertelrud
added
the
ready
While
swift package describehad an entry fortarget_dependenciesin the output of each target, it omittedproduct_dependencies.Motivation:
Currently (while we still have the distinction between products and targets in the SwiftPM package model) we should include both kinds of dependencies in the package description output format.
Modifications: