Rename experimental-api-diff -> dianose-api-breaking-changes #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci smoke test |
neonichu
approved these changes
Jul 23, 2021
elsh
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that this feature is tested on CI and the basic functionality is in place, I think it makes sense to drop the 'experimental' from its name. There are still a number of potential improvements, but no major issues that I know of
Motivation:
Rename experimental-api-diff -> dianose-api-breaking-changes to reflect its status as a more officially supported feature.
Modifications:
Result:
No functional changes other than the new name
This PR builds on #3622 just so I could avoid some merge conflicts in the tests