Update CODEOWNERS #3852
Update CODEOWNERS #3852
Conversation
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
| @@ -24,4 +24,4 @@ | |||
|
|
|||
| # The following lines are used by GitHub to automatically recommend reviewers. | |||
|
|
|||
| * @abertelrud @neonichu @tomerd @friedbunny | |||
| * @abertelrud @neonichu @tomerd @elsh | |||
There was a problem hiding this comment.
Intentional replacement (summary says to add)?
There was a problem hiding this comment.
Also, should the section above be updated while it's being edited (with the N, E, D, etc)?
There was a problem hiding this comment.
I thought it was just comments but I think Rick said it gets parsed by GitHub.
There was a problem hiding this comment.
added. I think it makes sense to keep Daniel and Ankit info in that section since they show up in commit history, correct?
There was a problem hiding this comment.
Intentional replacement (summary says to add)?
yes I believe @friedbunny would be less involved in these going forward
| @@ -24,4 +24,4 @@ | |||
|
|
|||
| # The following lines are used by GitHub to automatically recommend reviewers. | |||
|
|
|||
| * @abertelrud @neonichu @tomerd @friedbunny | |||
| * @abertelrud @neonichu @tomerd @elsh | |||
There was a problem hiding this comment.
Also, should the section above be updated while it's being edited (with the N, E, D, etc)?
| @@ -24,4 +24,4 @@ | |||
|
|
|||
| # The following lines are used by GitHub to automatically recommend reviewers. | |||
|
|
|||
| * @abertelrud @neonichu @tomerd @friedbunny | |||
| * @abertelrud @neonichu @tomerd @elsh | |||
There was a problem hiding this comment.
I thought it was just comments but I think Rick said it gets parsed by GitHub.
add @elsh to CODEOWNERS