refactor RelativePath to allow late stage canonicalization in support of windows #5910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
changed the title
tomerd
changed the title
|
companion: apple/swift-tools-support-core#369 |
|
@compnerd should we rekindle this + the TSC PR so we can support Windows with less patches? |
|
@tomerd yes please! I would like to get this sorted out because it enables the test suite on Windows. |
|
@tomerd could you rebase this please? |
tomerd
force-pushed
the
refactor/relative-path
branch
from
f3a4016
to
18d81fb
Compare
|
@compnerd this is updated |
tomerd
force-pushed
the
refactor/relative-path
branch
from
18d81fb
to
1b66afd
Compare
|
apple/swift-tools-support-core#369 @swift-ci smoke test |
tomerd
commented
Apr 13, 2023
| @@ -1832,7 +1833,7 @@ class PackageBuilderTests: XCTestCase { | |||
| PackageBuilderTester(manifest, path: "/pkg", in: fs) { _, diagnostics in | |||
| diagnostics.check(diagnostic: "target path \'~/foo\' is not supported; it should be relative to package root", severity: .error) | |||
| } | |||
| } | |||
| }*/ | |||
There was a problem hiding this comment.
@neonichu @abertelrud to confirm, per our discussion apple/swift-tools-support-core#369 (comment) this is is correct to be removed
tomerd
changed the title
tomerd
force-pushed
the
refactor/relative-path
branch
from
a5a5c75
to
0a56e0c
Compare
|
apple/swift-tools-support-core#369 @swift-ci smoke test |
1 similar comment
|
apple/swift-tools-support-core#369 @swift-ci smoke test |
|
apple/swift-tools-support-core#369 @swift-ci smoke test macOS |
tomerd
changed the title
|
Local run of the test suite: |
|
Overall, I think that if we fix the three assertion failures, this might not be a bad point to draw in the sand. |
|
apple/swift-tools-support-core#369 @swift-ci smoke test Windows |
|
@compnerd are these test error on Windows? I dont see them on linux / mac. if so, which specific failures are the ones you are more worried about? some of them seem to be unrelated to this change |
|
apple/swift-tools-support-core#369 @swift-ci smoke test windows |
|
@compnerd looks like the windows build is broken? |
|
Yeah, apple/swift#65198 should fix it |
|
Please test with following PRs: @swift-ci please test Windows platform |
|
Please test with following PRs: @swift-ci please test Windows platform |
|
@swift-ci please smoke test |
|
Please test with following PRs: @swift-ci please smoke test |
|
self hosted expected to fail since they do not support cross repo testing |
|
apple/swift#65183 @swift-ci smoke test linux |
|
apple/swift#65183 @swift-ci smoke test macos self-hosted |
neonichu
reviewed
Apr 17, 2023
neonichu
reviewed
Apr 17, 2023
neonichu
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Looks good in general, but I am not sure I like the use of try! outside of tests. I called out a couple of specific places where we should change it, but I'm generally slightly against it. It seems too easy for a change to make the use unsafe without actually changing the call sites to a proper throws.
tomerd
force-pushed
the
refactor/relative-path
branch
from
65f21f0
to
fac1c64
Compare
|
apple/swift-tools-support-core#369 @swift-ci smoke test macos self-hosted |
|
apple/swift-tools-support-core#369 @swift-ci smoke test |
|
apple/swift-tools-support-core#369 @swift-ci smoke test windows |
|
self-hosted expected to fail since they do not support cross repo testing |
|
apple/swift-tools-support-core#369 @swift-ci smoke test macOS |
|
apple/swift-tools-support-core#369 @swift-ci smoke test windows |
This was referenced Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: delay canonicalization of relative path to the construction of absolute path from it, to better fit how windows paths work
changes: