Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable disabled tests #5957

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Reenable disabled tests #5957

merged 3 commits into from
Dec 8, 2022

Conversation

neonichu
Copy link
Member

@neonichu neonichu commented Dec 8, 2022

This reenables several disabled tests and reverts an incorrect change to the bootstrap script.

These tests were disabled but proven working again.

rdar://101868275
This reverts commit 59dc518.

This change was incorrect, `bootstrap` is in fact creating a symlink to the inferior compiler for testing, so overriding `SWIFT_EXEC` is incorrect.
@neonichu neonichu self-assigned this Dec 8, 2022
@neonichu
Copy link
Member Author

neonichu commented Dec 8, 2022

@swift-ci please smoke test

@neonichu
Copy link
Member Author

neonichu commented Dec 8, 2022

Looks like we have some bit rot in the FunctionalTests that were disabled?

@neonichu
Copy link
Member Author

neonichu commented Dec 8, 2022

@swift-ci please smoke test

@neonichu neonichu enabled auto-merge (squash) December 8, 2022 08:11
@neonichu neonichu merged commit c6faab7 into main Dec 8, 2022
@neonichu neonichu mentioned this pull request Dec 9, 2022
@neonichu neonichu deleted the re-enable-tests branch December 9, 2022 00:20
neonichu added a commit that referenced this pull request Dec 9, 2022
This reverts commit c6faab7.

The failure showed up again in #5950, so it's not actually gone.
neonichu added a commit that referenced this pull request Dec 9, 2022
This reverts commit c6faab7.

The failure showed up again in #5950, so it's not actually gone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants