Basics: clean up DiagnosticsEngine in Observability
#6333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since uses of `DiagnosticsEngine` are deprecated in SwiftPM, with apple/swift-driver#1317 we can remove any traces of it from `Basics/Observability.swift` to clean that up.
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci test |
|
@swift-ci smoke test |
|
our end goal is to deprecate the entire TSCBasic.Diagnostic(*) feature-set, and while this does not get us there this seems like a good step forward 👍 |
tomerd
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Since uses of
DiagnosticsEngineare deprecated in SwiftPM, with apple/swift-driver#1317 we can remove any traces of it fromBasics/Observability.swiftto clean that up.Modifications:
Removed unused deprecated function that returned an instance of
DiagnosticsEngine. Also broke upimport TSCBasicinto separate type imports to make clear what dependencies on TSC are there remaining.Result:
TSCBasic.Diagnosticstill remains, but I think long-term we can move that to Swift Driver codebase to reduce dependencies on TSC.