PackageLoading: anchor relative paths for Windows #6345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
neonichu
approved these changes
Mar 28, 2023
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
We currently cannot use `..` as a header search path for Windows even though it may be contained within the package root. This is due to the fact that the path itself was unanchored, and a raw `..` would be treated as the drive root which will almost always be outside of the package root. Construct the absolute path relative to the target root rather than appending, permitting us to form a well-formed path which can be checked for ancestry.
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
This was referenced May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently cannot use
..as a header search path for Windows even though it may be contained within the package root. This is due to the fact that the path itself was unanchored, and a raw..would be treated as the drive root which will almost always be outside of the package root. Construct the absolute path relative to the target root rather than appending, permitting us to form a well-formed path which can be checked for ancestry.