change validation to throw instead of pre-condition to avoid crashes #6354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: avoid crashes changes: throw and internal error instead of pre-condition when validation fails rdar://98522178
|
@swift-ci smoke test |
MaxDesiatov
approved these changes
Mar 30, 2023
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Mar 30, 2023
…pple#6354) motivation: avoid crashes changes: throw and internal error instead of pre-condition when validation fails rdar://98522178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: avoid crashes
changes: throw and internal error instead of pre-condition when validation fails
rdar://98522178