Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Target Grouping #6356

Merged
merged 2 commits into from Apr 3, 2023
Merged

Support Target Grouping #6356

merged 2 commits into from Apr 3, 2023

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Mar 31, 2023 •
edited

Support Target Grouping

  • Allow opting out of package boundary
  • Default set to package boundary

Resolves rdar://107454728

@elsh
Copy link
Contributor Author

elsh commented Mar 31, 2023

@swift-ci smoke test

@elsh elsh force-pushed the es-g4 branch 2 times, most recently from 2730807 to 35f70ce Compare March 31, 2023 08:56
@elsh elsh requested review from artemcm and tshortli March 31, 2023 08:57
@elsh
Copy link
Contributor Author

elsh commented Mar 31, 2023

@swift-ci smoke test

1 similar comment
@elsh
Copy link
Contributor Author

elsh commented Mar 31, 2023

@swift-ci smoke test

@neonichu
Copy link
Member

@swift-ci test windows

@elsh
Enable package-name setting for v5.9+
8ca2b79 
Support Target Grouping
- Allow opting out of package boundary
- Default set to package boundary

Resolves rdar://107454728
@elsh
Copy link
Contributor Author

elsh commented Mar 31, 2023

@swift-ci smoke test

neonichu
neonichu reviewed Mar 31, 2023
View reviewed changes
Sources/PackageDescription/Target.swift Show resolved Hide resolved
Sources/PackageDescription/Target.swift Show resolved Hide resolved
Sources/PackageDescription/Target.swift Outdated Show resolved Hide resolved
Sources/PackageModel/PackageModel.swift Outdated Show resolved Hide resolved
@elsh
Copy link
Contributor Author

elsh commented Mar 31, 2023

@swift-ci smoke test

@MaxDesiatov
Copy link
Member

@swift-ci smoke test macos

@MaxDesiatov
Copy link
Member

@swift-ci test windows

@elsh elsh merged commit aaa47e9 into main Apr 3, 2023
4 checks passed
@elsh elsh deleted the es-g4 branch April 3, 2023 20:38
@elsh elsh mentioned this pull request Apr 3, 2023
Merged
neonichu added a commit that referenced this pull request Apr 7, 2023
@neonichu
Add a minimal test for the PD macro API
a3c1918 
This should avoid regressions like the one introduced by #6356
@neonichu neonichu mentioned this pull request Apr 7, 2023
Merged
neonichu added a commit that referenced this pull request Apr 10, 2023
@neonichu
Add a minimal test for the PD macro API (#6399)
7ef7f1d 
This should avoid regressions like the one introduced by #6356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@tomerd tomerd Awaiting requested review from tomerd tomerd is a code owner

@xymus xymus Awaiting requested review from xymus

@rjmccall rjmccall Awaiting requested review from rjmccall

@nkcsgexi nkcsgexi Awaiting requested review from nkcsgexi

@artemcm artemcm Awaiting requested review from artemcm

@tshortli tshortli Awaiting requested review from tshortli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elsh @neonichu @MaxDesiatov