Add author to collection package release metadata #6408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Motivation: Package collection should have information about how a version was created. This includes the creator and timestamp. - "Who created the package version?": added in this PR - "When was the version created?": this is version's `createdAt`, which already exists. rdar://106674475 Modifications: Extract `author` from GitHub API's release data and make it available through package collection's `Package` model.
yim-lee
force-pushed
the
collection-version-author
branch
from
6a9010d
to
4233ff3
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test macOS |
tomerd
approved these changes
Apr 11, 2023
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Apr 11, 2023
Motivation: Package collection should have information about how a version was created. This includes the creator and timestamp. - "Who created the package version?": added in this PR - "When was the version created?": this is version's `createdAt`, which already exists. rdar://106674475 Modifications: Extract `author` from GitHub API's release data and make it available through package collection's `Package` model.
yim-lee
added a commit
that referenced
this pull request
Apr 12, 2023
Motivation: Package collection should have information about how a version was created. This includes the creator and timestamp. - "Who created the package version?": added in this PR - "When was the version created?": this is version's `createdAt`, which already exists. rdar://106674475 Modifications: Extract `author` from GitHub API's release data and make it available through package collection's `Package` model.
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Apr 12, 2023
Motivation: Package collection should have information about how a version was created. This includes the creator and signer. apple#6408 added `author` populated using GitHub data, but we can allow package collection author to specify version creator as well. rdar://106674475 Modifications: - Add `author` and `signer` to package collection models - Update `PackageSearchClient` to use more information from collection/index results
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Apr 12, 2023
Motivation: Package collection should have information about how a version was created. This includes the creator and signer. apple#6408 added `author` populated using GitHub data, but we can allow package collection author to specify version creator as well. rdar://106674475 Modifications: - Add `author` and `signer` to package collection models - Update `PackageSearchClient` to use more information from collection/index results
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Apr 12, 2023
Motivation: Package collection should have information about how a version was created. This includes the creator and signer. apple#6408 added `author` populated using GitHub data, but we can allow package collection author to specify version creator as well. rdar://106674475 Modifications: - Add `author` and `signer` to package collection models - Update `PackageSearchClient` to use more information from collection/index results
yim-lee
added a commit
that referenced
this pull request
Apr 12, 2023
Motivation: Package collection should have information about how a version was created. This includes the creator and signer. #6408 added `author` populated using GitHub data, but we can allow package collection author to specify version creator as well. rdar://106674475 Modifications: - Add `author` and `signer` to package collection models - Update `PackageSearchClient` to use more information from collection/index results
yim-lee
added a commit
that referenced
this pull request
Apr 13, 2023
Motivation: Package collection should have information about how a version was created. This includes the creator and signer. #6408 added `author` populated using GitHub data, but we can allow package collection author to specify version creator as well. rdar://106674475 Modifications: - Add `author` and `signer` to package collection models - Update `PackageSearchClient` to use more information from collection/index results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Package collection should have information about how a version was created. This includes the creator and timestamp.
createdAt, which already exists.rdar://106674475
Modifications:
Extract
authorfrom GitHub API's release data and make it available through package collection'sPackagemodel.