Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Swift Macro template #6410

Merged
merged 4 commits into from Apr 11, 2023
Merged

Improve Swift Macro template #6410

merged 4 commits into from Apr 11, 2023

Conversation

ahoppen
Copy link
Contributor

@ahoppen ahoppen commented Apr 11, 2023

  • Use 4 spaces instead of 2 to be consistent with the other templates
  • Use BasicMacroExpansionContext( instead of BasicMacroExpansionContext.init
  • Add two newlines in the test method to improve readability
  • Depend on the latest 509.0.0 prerelease of SwiftSyntax instead of main.

@ahoppen
Copy link
Contributor Author

ahoppen commented Apr 11, 2023

@swift-ci Please smoke test

@ahoppen ahoppen mentioned this pull request Apr 11, 2023
Merged
@ahoppen ahoppen merged commit 9d3a531 into apple:main Apr 11, 2023
4 checks passed
@ahoppen ahoppen deleted the ahoppen/template-fixes branch April 11, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@tomerd tomerd Awaiting requested review from tomerd tomerd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahoppen @neonichu