Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: fix use of deprecated -Xmanifest flag #6435

Merged
merged 2 commits into from Apr 18, 2023

Conversation

MaxDesiatov
Copy link
Member

We should use -Xbuild-tools-swiftc instead, as the deprecation warning recommends.

We should use `-Xbuild-tools-swiftc` instead as the deprecation warning recommends
@MaxDesiatov
Copy link
Member Author

@swift-ci smoke test

@MaxDesiatov
Copy link
Member Author

macOS failure:

--- bootstrap: note: Building SwiftPM (with a freshly built swift-bootstrap)
Error: Missing value for '-c <configuration>'
Help:  -c <configuration>  Build with configuration
Usage: swift-bootstrap [--package-path <package-path>] [--scratch-path <scratch-path>] [--configuration <configuration>] [-Xcc <Xcc> ...] [-Xswiftc <Xswiftc> ...] [-Xlinker <Xlinker> ...] [-Xcxx <Xcxx> ...] [--verbose] [--very-verbose] [--use-integrated-swift-driver]
  See 'swift-bootstrap --help' for more information.

I wonder if this could be caused by a bug in ArgumentParser?

@neonichu
Copy link
Member

IIRC, swift-bootstrap has its own set of arguments that's more restrictive than regular swift build, so we may need to add the new argument there. It doesn't need deprecation since it is supposed to be build from source when used, so maybe we can just rename it.

@MaxDesiatov
Copy link
Member Author

@swift-ci smoke test

@MaxDesiatov
Copy link
Member Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov merged commit b6fc418 into main Apr 18, 2023
5 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/fix-bootstrap-deprecation branch April 18, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants