reduce use of byte string #6497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
neonichu and
MaxDesiatov
as code owners
|
@swift-ci smoke test |
motivation: prepare to deprecating byte string changes: * use strings when writing files * improve file writing utility to create directory first (add TSC inconsistency) * update call sites, mostly in tests
tomerd
force-pushed
the
refactor/reduce-use-of-byte-string
branch
from
fd82b51
to
4f3ddb2
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
MaxDesiatov
approved these changes
Apr 29, 2023
|
@swift-ci smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: prepare to deprecating byte string
changes: