SourceControl: centralise git cloning #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
neonichu
approved these changes
May 12, 2023
The `progresHandler` is the callback and specifying it will attach `--progress` to the invocation and will perform the callback.
|
@swift-ci please smoke test |
tomerd
reviewed
May 12, 2023
tomerd
reviewed
May 12, 2023
tomerd
reviewed
May 12, 2023
tomerd
reviewed
May 12, 2023
|
I'll rebuild SwiftFormat and run it through. I really wish that we could run that in CI. |
tomerd
reviewed
May 12, 2023
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Create a helper to invoke `git clone` since we pass a few options to the invocation. This ensures that we always clone a repository with the same set of options and that we do not need to keep the various sites in sync.
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralise the git clone command invocation to ensure that we uniformly handle the arguments for the clone. This sets the stage for further tweaks needed to fix cloning some repositories on Windows.