[5.9] Registry login interactive mode cannot read password/token over 128 chars long #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hars long (apple#6562) * Registry login interactive mode cannot read password/token over 128 chars long Motivation: `swift package-registry login` in interactive mode truncates input when the provided password/token is more than 128 chars long. This is a limitation of `getpass`. rdar://109372320 Modifications: - Use `readpassphrase`, which allows custom input length, instead of `getpass`. - Improve error message when the provided password/token is too long. - Increase password/token length limit to 512 chars * Continue using getpass on non-Darwin, non-Windows platforms * include more details in Windows error messages
|
@swift-ci please smoke test |
tomerd
approved these changes
May 25, 2023
neonichu
approved these changes
May 25, 2023
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #6562