Add support for Musl libc #6666
Conversation
Since Musl is sufficiently different from Glibc (see https://wiki.musl-libc.org/functional-differences-from-glibc.html), it requires a different import, which now should be applied to files that previously had `import Glibc` in them.
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
|
@swift-ci smoke test |
100%, but until then we have to import platform-specific libcs explicitly. |
| sigaction(SIGINT, &action, nil) | ||
| kill(getpid(), SIGINT) | ||
| #endif |
There was a problem hiding this comment.
this diff looks like it is doing more than just Musl support?
There was a problem hiding this comment.
I think this is just code rearrangement; every case did
sigaction(SIGINT, &action, nil)
kill(getpid(), SIGINT)
and I think Max just moved it outside of the #if conditions.
There was a problem hiding this comment.
Yes, those lines are common for all cases, they only differ in handler setup.
…xd/canimport-musl # Conflicts: # Sources/swiftpm-xctest-helper/main.swift
|
@swift-ci smoke test |
|
@swift-ci test windows |
This has already been pitched. Would you take that over, @MaxDesiatov, since you are adding Musl, including adding Bionic and the BSD libcs? I'll be happy to help split off Bionic, I just don't want to push all this through the Evolution process. |
Since Musl is sufficiently different from Glibc (see https://wiki.musl-libc.org/functional-differences-from-glibc.html), it requires a different import, which now should be applied to files that have
import Glibcin them.