Skip compiling plugins when skipping building #6696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
MaxDesiatov
reviewed
Jul 11, 2023
MaxDesiatov
reviewed
Jul 11, 2023
MaxDesiatov
reviewed
Jul 11, 2023
MaxDesiatov
approved these changes
Jul 11, 2023
|
I wonder if this can be tested? |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
It looks like we have an existing test for |
Sink `shouldSkipBuilding` down into build parameters, so we can respect it whereever we would be trying to build, e.g. when trying to build plugins during build planning. resolves #6683 Co-authored-by: Max Desiatov <m_desiatov@apple.com>
neonichu
force-pushed
the
skip-plugins-when-skipping-build
branch
from
99130fe
to
171ea56
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
tomerd
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sink
shouldSkipBuildingdown into build parameters, so we can respect it whereever we would be trying to build, e.g. when trying to build plugins during build planning.resolves #6683