improve diagnostics when running into multiple product conflicts #6792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
neonichu and
MaxDesiatov
as code owners
motivation: diagnostics for multiple products conflicts could be fairly confusing with repeated package identities and not enough informaiton about the origin of the conflict changes: * use PackageIdentity to track duplicates instead of strings * use Sets to track duplicates instead of array * add information about the origin (url) of the conflict * adjust tests rdar://113495991
tomerd
force-pushed
the
radar/113495991
branch
from
bdc075c
to
9eed89a
Compare
|
@swift-ci smoke test |
neonichu
approved these changes
Aug 10, 2023
|
Best to also include the radar number in the commit message / PR description for tracking purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: diagnostics for multiple products conflicts could be fairly confusing with repeated package identities and not enough informaiton about the origin of the conflict
changes:
rdar://113495991