Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tools-version for -user-module-version #6795

Merged
merged 1 commit into from Aug 11, 2023

Conversation

neonichu
Copy link
Member

We are not shipping this in 5.9, so we need to tweak this.

We are not shipping this in 5.9, so we need to tweak this.
@neonichu
Copy link
Member Author

@swift-ci please smoke test

@neonichu neonichu enabled auto-merge (squash) August 11, 2023 00:35
@neonichu neonichu merged commit d68fb6d into main Aug 11, 2023
5 checks passed
@neonichu neonichu deleted the update-tools-version-for-user-module-version branch August 11, 2023 02:53
@ole
Copy link

ole commented Jan 17, 2024

@neonichu I noticed the tools version gate for this is still set to .vNext in the current main and release/5.10 branches:

// Pass `-user-module-version` for versioned packages that aren't pre-releases.
if let version = package.manifest.version, version.prereleaseIdentifiers.isEmpty, version.buildMetadataIdentifiers.isEmpty, toolsVersion >= .vNext {
args += ["-user-module-version", version.description]
}

Is there anything blocking this from making it into Swift 5.10?

@MaxDesiatov
Copy link
Member

I've changed it to 5.10 in #7261

@ole
Copy link

ole commented Jan 17, 2024

@MaxDesiatov Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants