Tests: adjust SPMBuildCoreTests for Windows #6854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file system on Windows does not have nanosecond granularity (nor is this is a guaranteed file system feature on all file systems). Add a sleep before the execution to ensure that we have sufficient precision to read a difference.
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please clean test Windows platform |
MaxDesiatov
reviewed
Aug 25, 2023
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
compnerd
commented
Aug 25, 2023
|
@swift-ci please smoke test |
|
@swift-ci test windows |
|
@swift-ci please smoke test Windows platform |
MaxDesiatov
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file system on Windows does not have nanosecond granularity (nor is this is a guaranteed file system feature on all file systems). Add a sleep before the execution to ensure that we have sufficient precision to read a difference.