Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support experimental test summary on non-Darwin (#6878)" #6887

Merged
merged 1 commit into from Sep 13, 2023

Conversation

compnerd
Copy link
Collaborator

This reverts commit ca45050.

Tests on Windows do not function after this change:

[388/392] Emitting module SwiftWin32PackageTests
C:\a\swift-build\swift-build\SourceCache\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32PackageTests.derived\runner.swift:13:20: error: invalid escape sequence in literal

        return "C:\a\swift-build\swift-build\SourceCache\swift-win32\.build\x86_64-unknown-windows-msvc\debug\testOutput.txt"

@compnerd
Copy link
Collaborator Author

@swift-ci please smoke test

@neonichu
Copy link
Member

The issue probably lies here:

var testOutputPath: String {
    return "\(buildParameters.testOutputPath)"
}

Maybe using ._nativePathString(escaped: true) would do the right thing?

@compnerd
Copy link
Collaborator Author

@swift-ci please smoke test

@neonichu
Copy link
Member

@swift-ci please test

@neonichu
Copy link
Member

We recently asked @shahmishal for aliasing "test" to "smoke test" but I guess this made "smoke test" non-functional except for Windows?

@tomerd
Copy link
Member

tomerd commented Sep 13, 2023

@shahmishal @compnerd, @neonichu and myself were just chatting about windows CI for SwiftPM and not clear to us why it is only building and not running any of the tests (we were not involved in how it was set up). are we in a position to run the tests as well? this could helped avoid such rollback churn

@compnerd
Copy link
Collaborator Author

I'm going to merge this for now as this is actively blocking the use of SPM on Windows. Lets figure out how to get testing enabled to avoid this in the future.

@compnerd compnerd merged commit 1647820 into main Sep 13, 2023
5 checks passed
@compnerd compnerd deleted the revert-6878-experimental-test-output-on-linux branch September 13, 2023 14:48
MaxDesiatov pushed a commit that referenced this pull request Sep 28, 2023
MaxDesiatov pushed a commit that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants