Do not process code coverage when tests failed #6894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can currently lead to bogus output like
```
error: terminated(1): /Users/neonacho/Downloads/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/llvm-profdata merge -sparse -o /Users/neonacho/Desktop/lunch7/.build/arm64-apple-macosx/debug/codecov/default.profdata output:
error: no input files specified. See llvm-profdata merge -help
```
I would also think even if it succeeded, it could result in incorrect data.
rdar://115436056
|
@swift-ci please test |
MaxDesiatov
reviewed
Sep 14, 2023
| @@ -296,7 +296,7 @@ public struct SwiftTestTool: SwiftCommand { | |||
| swiftTool.executionStatus = .failure | |||
| } | |||
|
|
|||
| if self.options.enableCodeCoverage { | |||
| if self.options.enableCodeCoverage, ranSuccessfully { | |||
There was a problem hiding this comment.
Can this behavior be tested to avoid regressions?
There was a problem hiding this comment.
Probably, but I don't see any existing testing of the code-coverage feature at all.
tomerd
approved these changes
Sep 14, 2023
|
Going to merge this. I think it would be nice to have test coverage of the code coverage feature, but this doesn't necessarily seem like the place to start adding that. |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
This can currently lead to bogus output like
```
error: terminated(1): /Users/neonacho/Downloads/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/llvm-profdata merge -sparse -o /Users/neonacho/Desktop/lunch7/.build/arm64-apple-macosx/debug/codecov/default.profdata output:
error: no input files specified. See llvm-profdata merge -help
```
I would also think even if it succeeded, it could result in incorrect data.
rdar://115436056
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
This can currently lead to bogus output like
```
error: terminated(1): /Users/neonacho/Downloads/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/llvm-profdata merge -sparse -o /Users/neonacho/Desktop/lunch7/.build/arm64-apple-macosx/debug/codecov/default.profdata output:
error: no input files specified. See llvm-profdata merge -help
```
I would also think even if it succeeded, it could result in incorrect data.
rdar://115436056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can currently lead to bogus output like
I would also think even if it succeeded, it could result in incorrect data.
rdar://115436056