Disable the bootstrap checking for explicit target dependencies and remove wrong llbuild dependency #6909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove wrong llbuild dependency This is currently flagging wrong dependencies, enable it again once it works.
finagolfin
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
neonichu
approved these changes
Sep 16, 2023
|
@MaxDesiatov, a CI run here and we can get this in? I will submit for 5.10 next. |
|
@swift-ci please test |
|
Windows CI failed after checking out source, obviously unrelated to this pull. |
|
@swift-ci please test windows |
|
Ready for merge, I will submit for 5.10 next. |
|
We're in the process of setting up an automerger from main to 5.10, so submitting separately should not be necessary. |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
…emove wrong llbuild dependency (#6909) This is currently flagging wrong dependencies, enable it again once it works.
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
…emove wrong llbuild dependency (#6909) This is currently flagging wrong dependencies, enable it again once it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently flagging wrong dependencies, enable it again once it works.
@neonichu, reverting for now as you suggested.