Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swift-certificates to 1.0.1, swift-crypto to 3.0.0 #6949

Merged
merged 2 commits into from Oct 11, 2023

Conversation

yim-lee
Copy link
Member

@yim-lee yim-lee commented Sep 26, 2023

rdar://113969026
rdar://115794818

This PR requires update-checkout changes

@yim-lee yim-lee self-assigned this Sep 26, 2023
@yim-lee yim-lee marked this pull request as draft September 26, 2023 04:49
@yim-lee
Copy link
Member Author

yim-lee commented Sep 26, 2023

@swift-ci please smoke test

@yim-lee
Copy link
Member Author

yim-lee commented Sep 26, 2023

@swift-ci please test

@MaxDesiatov
Copy link
Member

MaxDesiatov commented Sep 26, 2023

I guess 1.0.0 is unsuitable and will cause Windows CI to always fail on the clone/checkout step, since apple/swift-certificates#142 is not included in that release?

@dnadoba
Copy link
Member

dnadoba commented Sep 26, 2023

We have just released 1.0.1 with the fix for windows.

Copy link
Member

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaxDesiatov
Copy link
Member

@swift-ci test

Package.swift Outdated Show resolved Hide resolved
@MaxDesiatov
Copy link
Member

@swift-ci test

@yim-lee
Copy link
Member Author

yim-lee commented Sep 26, 2023

Thanks @dnadoba @MaxDesiatov. I will make the update-checkout changes to point to swift-certificates 1.0.1.

@yim-lee yim-lee changed the title Update swift-certificates to 1.0.0, swift-crypto to 3.0.0 Update swift-certificates to 1.0.1, swift-crypto to 3.0.0 Sep 26, 2023
@yim-lee
Copy link
Member Author

yim-lee commented Sep 26, 2023

apple/swift#68768

@swift-ci please test

Copy link
Member

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yim-lee yim-lee marked this pull request as ready for review September 27, 2023 16:31
@shahmishal shahmishal merged commit d90d52e into apple:main Oct 11, 2023
5 checks passed
@yim-lee yim-lee deleted the swift-certs-1.0 branch October 11, 2023 04:36
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Oct 11, 2023
…0.0 (apple#6949)"

This reverts commit d90d52e.

Until update-checkout supports this change in 5.10.
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Oct 11, 2023
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Oct 11, 2023
shahmishal pushed a commit that referenced this pull request Oct 31, 2023
…o 3.0.0 (#6949)" (#6989)

This reverts the revert PR
#6988

**This requires update-checkout changes**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants