[NFC] Split LLBuildManifestBuilder.swift into extension files
#6966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LLBuildManifestBuilder.swift` is getting too big, especially when there's a need to add new commands for additional build steps. Fortunately, it's already separated out into multiple extensions, with different commands implemented in each extension. Let's move those extensions into separate files for better readability and easier discovery/navigation.
MaxDesiatov
changed the title
LLBuildManifestBuilder.swift into extension filesLLBuildManifestBuilder.swift into extension files
|
@swift-ci test |
neonichu
approved these changes
Oct 3, 2023
|
@swift-ci test |
|
@swift-ci test windows |
neonichu
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLBuildManifestBuilder.swiftis getting too big, especially when there's a need to add new commands for additional build steps. Fortunately, it's already separated out into multiple extensions, with different commands implemented in each extension. Let's move those extensions into separate files for better readability and easier discovery/navigation.