Handle macOS CLT --show-sdk-platform-path issues
#6977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
tomerd
approved these changes
Oct 6, 2023
MaxDesiatov
reviewed
Oct 6, 2023
MaxDesiatov
reviewed
Oct 6, 2023
We have been seeing this issue for a while when using SwiftPM from the CommandLineTools package: ``` ❯ /usr/bin/xcrun --sdk macosx --show-sdk-platform-path xcrun: error: unable to lookup item 'PlatformPath' from command line tools installation xcrun: error: unable to lookup item 'PlatformPath' in SDK '/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk' ``` This changes SwiftPM to handle this gracefully during builds (a warning gets emitted) and to fail properly when running `swift test`. rdar://107479428
neonichu
force-pushed
the
handle-no-PlatformPath
branch
from
56031b2
to
d783dfc
Compare
|
@swift-ci please test |
|
From the Windows build:
😞 |
|
Looks like the Windows build succeeded now, but the status on GH hasn't been updated. |
|
I guess there's a few minute delay, it looks green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been seeing this issue for a while when using SwiftPM from the CommandLineTools package:
This changes SwiftPM to handle this gracefully during builds (a warning gets emitted) and to fail properly when running
swift test.rdar://107479428