Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: cover testing multiple async executable targets #6986

Merged
merged 2 commits into from Oct 13, 2023

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 11, 2023

Test apple/swift#69113: [Concurrency] Hide async_Main from other object files

Merge after the above fix will be merged

Motivation:

To verify that multiple executable targets with async entrypoints can be linked within a single test executable

Resolves rdar://114231968

Modifications:

Added a new test case

@neonichu
Copy link
Member

Thanks!

@kateinoigakukun kateinoigakukun marked this pull request as ready for review October 11, 2023 18:45
@kateinoigakukun
Copy link
Member Author

@swift-ci Please smoke test

@MaxDesiatov
Copy link
Member

@swift-ci test

@neonichu
Copy link
Member

I guess we need some way to skip these tests in the self-hosted environment, because they won't have a new enough compiler any time soon.

@kateinoigakukun
Copy link
Member Author

@neonichu I don't have a good and stable idea to detect if the given swift-frontend has the fix or not 🤔 I think we can wait to merge this until the next nightly toolchain will be shipped.

@kateinoigakukun
Copy link
Member Author

Ah, it looks like macOS self-hosted CI uses Xcode toolchain, so just waiting the next nightly doesn't work.

@MaxDesiatov MaxDesiatov added the next waiting for next merge window label Oct 11, 2023
@MaxDesiatov
Copy link
Member

Yeah, "next" here means next version of Xcode, for which we can't provide a schedule.

@MaxDesiatov
Copy link
Member

Maybe tests could be gated on the version of Swift, 5.10 I guess?

@kateinoigakukun
Copy link
Member Author

The async version test is split out from the sync version and guarded by #if compiler(<5.10). I think this should work without waiting for the next Xcode update in the CI and just need to wait for the next Linux nightly toolchain.

@neonichu
Copy link
Member

@swift-ci test

1 similar comment
@kateinoigakukun
Copy link
Member Author

@swift-ci test

@neonichu
Copy link
Member

I believe Linux self-hosted uses a nightly toolchain, so we have to wait until that contains the compiler changes.

@MaxDesiatov
Copy link
Member

@swift-ci test linux

@neonichu neonichu merged commit ea99df2 into apple:main Oct 13, 2023
5 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/test-multi-async-exe branch October 13, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next waiting for next merge window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants