Do not use canonical location for checkouts

[neonichu]

In #6780, we switched to using the canonical location of a package for the checkouts paths, but that can lead to mixing up checkouts storage when there has been a legitimate change to locations that isn't reflected in the canonical location (most prominently switching from SSH to HTTPS or vice versa). Because of that, we should undo that change.

rdar://116534183

[neonichu]

@swift-ci please test

[neonichu]

I missed this test, need to update:

[1614/1614] Testing CommandsTests.TestToolTests/testList
Test Suite 'Selected tests' started at 2023-10-13 20:08:41.286Test Suite 'RepositoryManagerTests' started at 2023-10-13 20:08:41.288Test Case 'RepositoryManagerTests.testCanonicalLocation' started at 2023-10-13 20:08:41.288/home/build-user/swiftpm/Tests/SourceControlTests/RepositoryManagerTests.swift:336: error: RepositoryManagerTests.testCanonicalLocation : XCTAssertEqual failed: ("foo-b1347716") is not equal to ("foo-926b93f1") -/home/build-user/swiftpm/Tests/SourceControlTests/RepositoryManagerTests.swift:336: error: RepositoryManagerTests.testCanonicalLocation : XCTAssertEqual failed: ("foo-4171dede") is not equal to ("foo-926b93f1") -/home/build-user/swiftpm/Tests/SourceControlTests/RepositoryManagerTests.swift:336: error: RepositoryManagerTests.testCanonicalLocation : XCTAssertEqual failed: ("foo-9e3a7536") is not equal to ("foo-926b93f1") -Test Case 'RepositoryManagerTests.testCanonicalLocation' failed (0.004 seconds)Test Suite 'RepositoryManagerTests' failed at 2023-10-13 20:08:41.292Executed 1 test, with 3 failures (0 unexpected) in 0.004 (0.004) secondsTest Suite 'Selected tests' failed at 2023-10-13 20:08:41.292Executed 1 test, with 3 failures (0 unexpected) in 0.004 (0.004) seconds

[neonichu]

Hm, I think the only way to handle this is to delete the test, but that doesn't seem entirely right to me since we do want to preserve that "http://scm.com/org/foo" and "http://scm.com/org/foo.git" would get the same storage location, but right now with the changes from this PR, they don't.

[tomerd]

Hm, I think the only way to handle this is to delete the test, but that doesn't seem entirely right to me since we do want to preserve that "http://scm.com/org/foo" and "http://scm.com/org/foo.git" would get the same storage location, but right now with the changes from this PR, they don't.

that would require using something similar but different from CanonicalLocation, eg something that removes the .git suffix

[neonichu]

@swift-ci please test

[neonichu]

@swift-ci please test windows

[neonichu]

WorkspaceTests.testDeterministicURLPreference expects that http and https locations are considered the same, I am not sure that is a reasonable expectation?

[neonichu]

Ah the issue here is that I am changing what equality of CanonicalPackageLocation does without realizing it. In the common case, we don't want the scheme to affect equality.

[neonichu]

@swift-ci please test

[neonichu]

@swift-ci please test windows