[NFC] CoreCommands: simplify *get-task-allow-entitlement flags
#7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
added
the
no functional change
|
@swift-ci test |
tomerd
approved these changes
Oct 23, 2023
|
@swift-ci test windows |
|
@swift-ci test macos |
neonichu
approved these changes
Oct 24, 2023
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Following up on feedback to #7010, it's better to have a single optional boolean flag than two non-optional booleans.
Modifications:
Replaced
var enableGetTaskAllowEntitlement = falseandvar disableGetTaskAllowEntitlement = falsewithvar getTaskAllowEntitlement: Bool? = nil, which has an additionalinversion: .prefixedEnableDisableconfiguration.Result:
Code that handles these flags is simpler and easier to read.