Fix broken links in documentation for PackageRegistry #7070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spqw
changed the title
MaxDesiatov
reviewed
Nov 9, 2023
| @@ -127,8 +127,8 @@ and apply them automatically when making registry API requests. | |||
| ## Dependency Resolution Using Registry | |||
|
|
|||
| Resolving a registry dependency involves these steps: | |||
| 1. Fetch a package's available versions by calling the [list package releases](https://github.com/apple/swift-package-manager/blob/main/Documentation/Registry.md#41-list-package-releases) API. | |||
| 2. Compute the dependency graph by [fetching manifest(s) for a package release](https://github.com/apple/swift-package-manager/blob/main/Documentation/Registry.md#43-fetch-manifest-for-a-package-release). | |||
| 1. Fetch a package's available versions by calling the [list package releases](https://github.com/apple/swift-package-manager/blob/main/Documentation/PackageRegistry/Registry.md#41-list-package-releases) API. | |||
There was a problem hiding this comment.
Can this use relative links instead, to avoid possible future breakage?
Suggested change
| 1. Fetch a package's available versions by calling the [list package releases](https://github.com/apple/swift-package-manager/blob/main/Documentation/PackageRegistry/Registry.md#41-list-package-releases) API. | |
| 1. Fetch a package's available versions by calling the [list package releases](Registry.md#41-list-package-releases) API. |
There was a problem hiding this comment.
Yes – it does work. Nice one. Applying changes now
|
@swift-ci test |
yim-lee
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken link - https://github.com/apple/swift-package-manager/blob/main/Documentation/Registry.md
Good link - https://github.com/apple/swift-package-manager/blob/main/Documentation/PackageRegistry/Registry.md