Remove experimental prefix from Swift SDK command
#7507
Conversation
MaxDesiatov
added
cross-compilation
cmake
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
|
@bnbarham @euanh @kateinoigakukun do you think it's worth keeping old subcommand and argument and make them show a deprecation warning for backwards compatibility? |
|
Yeah I think that'd be nice as long as we hide it from help in general. |
|
Also, it might be a good timing to refine CLI option consistency with others.
|
|
Not sure about that one, might require a proposal amendment as we've specified commands and their behavior explicitly in the proposal text. |
|
@MaxDesiatov Ok, I created a proposal amendment apple/swift-evolution#2424 |
|
IIUC amendments go through the same process as the rest of Swift Evolution. What I mean is that we'd probably have to run this as a pitch first, schedule this for review with the Swift Evolution stakeholders if there's enough positive feedback on the pitch, then run a formal review and follow on the review decision after that. |
|
Given that this is a non-functional and just a naming change, I feel going through the evolution process is too much for this change TBH... But I can follow the process if it's really necessary. I'd like to hear @bnbarham's opinion here. |
It'd be worth posting in |
…ounterparts (#7515) Cherry-pick of #7512, #7507, and #7517. **Explanation**: Since [SE-0387](https://github.com/apple/swift-evolution/blob/main/proposals/0387-cross-compilation-destinations.md) was accepted and available in Swift 5.9 and Swift 5.10, it's time to deprecate relevant CLI with the `experimental` prefix. There are enough users of this command and corresponding options on `swift build` in the wild, which means those should be deprecated first before removing. **Scope**: isolated to `swift sdk` command and 2 Swift SDK options on `swift build`. **Risk**: low, these commands options have no impact on `swift build` outside of cross-compilation use cases. **Testing**: added new end-to-end tests in `SDKCommandTests` in #7517 cherry-picked here. **Issue**: N/A **Reviewer**: @bnbarham
Since [SE-0387](https://github.com/apple/swift-evolution/blob/main/proposals/0387-cross-compilation-destinations.md) was accepted and available in Swift 5.9 and Swift 5.10, it's time to remove `experimental` prefix.
Since [SE-0387](https://github.com/apple/swift-evolution/blob/main/proposals/0387-cross-compilation-destinations.md) was accepted and available in Swift 5.9 and Swift 5.10, it's time to remove `experimental` prefix.
Since SE-0387 was accepted and available in Swift 5.9 and Swift 5.10, it's time to remove
experimentalprefix.