SR-3001: Generated Xcode project has an incorrect linkage on an executable #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…incorrect linkage on an executable The Xcode project model does not tie the concepts of dependency and linkage together; this was a problem in the logic that constructed that model.
abertelrud
changed the title
|
LGTM, Awesome! |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated Xcode project has an incorrect linkage on an executable. The Xcode project model does not tie the concepts of dependency and linkage together; this was a problem in the logic that constructed that model. It unconditionally added a linkage, but should only do so for dependencies on library modules.
Verified that the newly added unit test fails without the fix.