SR-3086: Xcode project generation puts modules from external packages together with local ones #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n; this is just to make the next diff containing the actual changes more clear.
… generated Xcode project, and add modules from the external packages to appropriate directories underneath. This is just a structure navigator change; there is no change to linkage semantics. This addresses https://bugs.swift.org/browse/SR-3086 "Xcode project generation puts modules from external packages together with local ones".
|
@swift-ci Please test |
|
macOS failure seems to be in Swift itself. |
|
Did you experience also trouble with SourceKit based on this? Since Xcode 8.1 and the version of SPM, I don't have code completion for generated xcode projects with the package manager. |
|
@swift-ci please test linux |
|
@swift-ci please test OS X |
|
Are we to re-install the package manager? |
|
Kitura/Kitura#822 is the same issue. |
|
There are some comments at Kitura/Kitura#822 about using the older package manager from SPM 3 to generate the xcode project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When external packages are present, add a
Dependenciesgroup, and add modules from the external packages to appropriate directories underneath. This is just a structure navigator change; there is no change to linkage semantics. The structure of the groups tries to respect whether the package uses shallow or deep package format, but does not depend on all of the package dependencies ending up inside aPackagessubdirectory in the source.This addresses https://bugs.swift.org/browse/SR-3086
The diffs are staged into three separate commits to make them easier to read.