[ProcessTests] Use ps -p to check if subprocess is running #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitspd
force-pushed
the
determ-sigkill-test
branch
from
f7d6096
to
2e31e93
Compare
neonichu
approved these changes
Jan 4, 2017
| XCTAssertFalse(running(ProcessID(child))) | ||
| #endif | ||
| XCTAssertFalse(try running(ProcessID(parent))) | ||
| // The child process becomes defunct when executing the tests using docker directly without entering bash. |
There was a problem hiding this comment.
Might make sense to mark this as a FIXME to eventually investigate why that might be the case and/or if it is something we should maybe handle/workaround in Process.
This is more deterministic than using getpgid() for linux. - https://bugs.swift.org/browse/SR-3538
ankitspd
force-pushed
the
determ-sigkill-test
branch
from
2e31e93
to
8fd31eb
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more deterministic than using getpgid() for linux.