[Utility] Cleaned up api for ProcessSet. #942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciidgh
requested changes
Feb 9, 2017
Sources/Utility/ProcessSet.swift
Outdated
| thread.join() | ||
| // Wait until all processes terminate | ||
| for process in self.processes { | ||
| try process.waitUntilExit() |
There was a problem hiding this comment.
can we make this try? and this method as non throwing
| @@ -70,7 +69,7 @@ class ProcessSetTests: XCTestCase { | |||
| threadStartCondition.wait() | |||
| } | |||
| } | |||
| processSet.terminate() | |||
| try processSet.terminate() | |||
|
|
|||
| t.join() | |||
There was a problem hiding this comment.
Did you see time taken by the test testSigInt before and after waitUntilAfter() in process set? There should be a noticeable difference I think.
There was a problem hiding this comment.
I didn't actually notice any major difference. 😕
Steveybrown
force-pushed
the
process-set-api-improvements
branch
from
994acee
to
c78c674
Compare
aciidgh
requested changes
Feb 10, 2017
Sources/Utility/ProcessSet.swift
Outdated
| /// Terminate all the processes. This method blocks until all processes in the set are terminated. | ||
| /// | ||
| /// A process set cannot be used once it has been asked to terminate. | ||
| /// Throws: If an error occurs during the wait for a process to terminate. |
Clients are no longer required to call remove on a process set.
Steveybrown
force-pushed
the
process-set-api-improvements
branch
from
c78c674
to
f52ca43
Compare
|
@swift-ci please test |
|
I opened #951 with a small addition to this patch Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients are no longer required to call remove on a process set.