Init package refactor #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2017 18:17
…the SwiftPM dynamic library.
- Move the source to the Workspace module
- Renamed InitMode enum to PackageType and nested it within the InitPackage class.
- Renamed a couple properties on InitPackage
- Introduced a progress reporter block so that InitPackage doesn't always just print to stdout.
- Moved ToolsVersionWriter into Workspace as well.
- Updated SwiftPackageTool to adapt changes (and to provide a progress reporter that prints to stdout)
- Added a new InitTests to the WorkspaceTests module
- Added tests for creating each of the four current package types
- Moved another existing init test that testes a specific special case with non C99 package names here to consolidate all the primary init testing in one place.
- Moved ToolsVersionWriterTests from CommandsTests to WorkspaceTests to follow the underlying code.
|
@swift-ci please test |
ankitspd
approved these changes
Feb 21, 2017
| /// The name of the example package to create. | ||
|
|
||
| /// A block that will be called to report progress during package creation | ||
| public var progressReporter: ((String) -> Void)? |
| // Create a tools version with current version but with patch set to zero. | ||
| // We do this to avoid adding unnecessary constraints to patch versions, if | ||
| // the package really needs it, they should add it manually. | ||
| let version = ToolsVersion.currentToolsVersion.zeroedPatch | ||
|
|
||
There was a problem hiding this comment.
We try to avoid the whitespace diffs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is motivated by the ongoing hoisting of functionality that may be of use to clients other than the command line tools into the SwiftPM library.
The main change here is to move the InitPackage class from the Commands module to the Workspace module so it will be included in the library. This required also moving the new ToolsVersionWriter. Some tests were migrated as well, and a new test suite was added to test the InitPackage class directly as part of WorkspaceTests in addition to the command-line based tests in CommandsTests for package creation.
The pull request is split into two commits. The first moves all the functional code and the second moves and adds tests.