Try to get the performance harness running again... #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reuses some cmake logic from the protobuf dir, which isn't ideal, but at least CMake knows how to handle abseil. <whew!> Note: This now expects abseil and googletests to be already installed on the local system. A more ambitious setup here could potentially avoid that.
|
Not sure if you want to look at #605 at the same time, or if there's enough changed it's already effectively resolved. |
This resolves apple#605 -- the previous code would leave the local tree in a very confusing state. This is slower, but checks out the comparison commit to a completely separate directory with no relation to the local directory and also arranges for it to be completely cleaned up at the end.
|
I changed the handling for comparison checkouts -- it should avoid #605 now, though I still need to do more testing. |
thomasvl
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing changes to the protobuf build system broke the previous performance harness scripts.
I've rebuilt the C++ perf harness by using a CMake build script to build libprotobuf and the C++ harness together. This uses more of the protobuf build machinery than I'd like -- it could probably be simplified and made more robust.
This has some requirements:
brew install abseil googletestseems to suffice)