Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xfail for ReSwift 3.0 configurations #171

Merged
merged 2 commits into from
Mar 27, 2018
Merged

Add xfail for ReSwift 3.0 configurations #171

merged 2 commits into from
Mar 27, 2018

Conversation

clackary
Copy link
Contributor

Pull Request Description

Project ReSwift is failing when tested against both master and swift-4.2-branch. This PR adds an xfail to ReSwift's four 3.0 configurations.

master: Build #1520
swift-4.2-branch: Build #92

SR-7287 has been filed to track the source breakage.

@clackary
Copy link
Contributor Author

@swift-ci please test

@clackary clackary mentioned this pull request Mar 27, 2018
Merged
@clackary
Copy link
Contributor Author

@swift-ci please test

@clackary
Copy link
Contributor Author

@swift-ci please test

@clackary clackary merged commit f8681d5 into master Mar 27, 2018
aschwaighofer added a commit that referenced this pull request Mar 28, 2018
@aschwaighofer
Revert "Merge pull request #171 from apple/xfail-reswift"
8250650 
This reverts commit f8681d5, reversing
changes made to 0a6f56e.

It is passing again after John M's changes.
@clackary clackary deleted the xfail-reswift branch March 28, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clackary