Add ssamadgh/ModelAssistant to suite

[ssamadgh]

Pull Request Description

Added ModelAssistant Repository to Projects.json

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

• be an Xcode or swift package manager project
• support building on either Linux or macOS
• target Linux, macOS, or iOS/tvOS/watchOS device
• be contained in a publicly accessible git repository
• maintain a project branch that builds against Swift 4.0 and passes any unit tests
• have maintainers who will commit to resolve issues in a timely manner
• be compatible with the latest GM/Beta versions of Xcode and swiftpm
• add value not already included in the suite
• be licensed with one of the following permissive licenses:
  • MIT
• pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

[clackary]

@ssamadgh Thanks for opening this! Allow me some time to review, and I'll get testing started when review is complete.

[clackary]

I was unable to get ./project_precommit_check to pass with the current configuration. It failed because it couldn't find an Xcode workspace. This makes sense, because your project isn't configured as a workspace, but a regular Xcode project.

I've made a few changes locally, and was able to get it working by using a project configuration instead of workspace. These changes have been added as suggestions.

$ ./project_precommit_check ModelAssistant --earliest-compatible-swift-version 4.2
** CHECK **
--- Validating ModelAssistant Swift version 4.2 compatibility ---
--- Project configured to be compatible with Swift 4.2 ---
--- Checking ModelAssistant platform compatibility with Darwin ---
--- Platform compatibility check succeeded ---
--- Locating swiftc executable ---
$ xcrun -f swiftc
--- Checking installed Swift version ---
$ /Applications/Xcodes/PublicGMs/Xcode-10-GM.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --version
--- Version check succeeded ---
--- Executing build actions ---
$ ./runner.py --swift-branch swift-4.2-branch --swiftc /Applications/Xcodes/PublicGMs/Xcode-10-GM.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --projects projects.json --include-repos 'path == "ModelAssistant"' --include-versions 'version == "4.2"' --include-actions 'action.startswith("Build")'
PASS: ModelAssistant, 4.2, 1f1d37, ModelAssistant iOS, generic/platform=iOS
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- ModelAssistant checked successfully against Swift 4.2 ---

[clackary]

@swift-ci test

[ssamadgh]

@clackary I made a few changes in the library, and I hope to be passed with the @swift-ci test. May I ask you test it again?
@swift-ci Please test source compatibility.

[clackary]

@swift-ci test

[clackary]

@ssamadgh Yes, I'd be happy to test again. The only way to start testing for this is for someone in the Swift Committers group to use @swift-ci test. Don't worry about updating the title.

Looking at the most recent failure, this may be a compiler crash. Let's see if it still happens after your changes to the library.

[clackary]

Looks like this is crashing in the same way as before. I've filed SR-9102 to investigate. For the meantime, we can xfail this to be able to get it merged.

[clackary]

Please add xfail as suggested.

[ssamadgh]

@clackary I committed the changes. @swift-ci test.

[clackary]

@swift-ci test

[clackary]

@ssamadgh Thanks for setting this up!

[ssamadgh]

@clackary Thanks for merging. What should I do if I updated my repository?
Is it enough to update the commit hash?

[clackary]

Since you are the project maintainer, it's up to you how often you'd like to update the commit hash. Feel free to open a pull request with a new hash any time.

From what I've seen with other projects, this usually happens when updating to a new Swift version, or when there are large and significant changes to a project.