New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LineSDK to compatibility suite #295
Conversation
@onevcat Thanks for the pull request! This passed
|
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the xfail as shown, since there's already an issue tracking the crash.
Would you also mind moving the project entry to be between the Lark
and ModelAssistant
projects? We like to keep projects sorted by path field.
projects.json
Outdated
"workspace": "LineSDK.xcworkspace", | ||
"scheme": "LineSDK", | ||
"destination": "generic/platform=iOS", | ||
"configuration": "Release" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"configuration": "Release" | |
"configuration": "Release", | |
"xfail": { | |
"compatibility": { | |
"4.2": { | |
"branch": { | |
"master": "https://bugs.swift.org/browse/SR-9375" | |
} | |
} | |
} | |
} |
@clackary Thanks. I made the changes you suggested. |
@swift-ci test |
@onevcat Merged. Thanks! |
Pull Request Description
This PR contains the setting for LineSDK project (https://github.com/line/line-sdk-ios-swift).
It is suggested by @jrose-apple in https://bugs.swift.org/browse/SR-9375 and contains a crash for Swift 5 toolchain (Swift Development Snapshot 2018-11-28 (a)).
Acceptance Criteria
To be accepted into the Swift source compatibility test suite, a project must:
./project_precommit_check
script runEnsure project meets all listed requirements before submitting a pull request.