Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LineSDK to compatibility suite #295

Merged
merged 2 commits into from Dec 11, 2018
Merged

Add LineSDK to compatibility suite #295

merged 2 commits into from Dec 11, 2018

Conversation

onevcat
Copy link
Contributor

@onevcat onevcat commented Dec 3, 2018

Pull Request Description

This PR contains the setting for LineSDK project (https://github.com/line/line-sdk-ios-swift).

It is suggested by @jrose-apple in https://bugs.swift.org/browse/SR-9375 and contains a crash for Swift 5 toolchain (Swift Development Snapshot 2018-11-28 (a)).

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • BSD
    • MIT
    • Apache License, version 2.0
    • Eclipse Public License
    • Mozilla Public License (MPL) 1.1
    • MPL 2.0
    • CDDL
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

@clackary
Copy link
Contributor

clackary commented Dec 3, 2018

@onevcat Thanks for the pull request!

This passed project_precommit_check locally.

$ ./project_precommit_check line-sdk-ios-swift --earliest-compatible-swift-version 4.2 
** CHECK **
--- Validating line-sdk-ios-swift Swift version 4.2 compatibility ---
--- Project configured to be compatible with Swift 4.2 ---
--- Checking line-sdk-ios-swift platform compatibility with Darwin ---
--- Platform compatibility check succeeded ---
--- Locating swiftc executable ---
$ xcrun -f swiftc
--- Checking installed Swift version ---
$ /Applications/Xcodes/PublicGMs/Xcode-10.0-GM.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --version
--- Version check succeeded ---
--- Executing build actions ---
$ ./runner.py --swift-branch swift-4.2-branch --swiftc /Applications/Xcodes/PublicGMs/Xcode-10.0-GM.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc --projects projects.json --include-repos 'path == "line-sdk-ios-swift"' --include-versions 'version == "4.2"' --include-actions 'action.startswith("Build")'
PASS: line-sdk-ios-swift, 4.2, d8bb2b, LineSDK, generic/platform=iOS
========================================
Action Summary:
     Passed: 1
     Failed: 0
    XFailed: 0
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: PASS
========================================
--- line-sdk-ios-swift checked successfully against Swift 4.2 ---

@clackary
Copy link
Contributor

clackary commented Dec 3, 2018

@swift-ci test

@clackary
Copy link
Contributor

clackary commented Dec 3, 2018

The build log shows the same crash as in SR-9375, so this is expected.

Copy link
Contributor

@clackary clackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the xfail as shown, since there's already an issue tracking the crash.

Would you also mind moving the project entry to be between the Lark and ModelAssistant projects? We like to keep projects sorted by path field.

projects.json Outdated
"workspace": "LineSDK.xcworkspace",
"scheme": "LineSDK",
"destination": "generic/platform=iOS",
"configuration": "Release"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"configuration": "Release"
"configuration": "Release",
"xfail": {
"compatibility": {
"4.2": {
"branch": {
"master": "https://bugs.swift.org/browse/SR-9375"
}
}
}
}

@onevcat
Copy link
Contributor Author

onevcat commented Dec 4, 2018

@clackary Thanks. I made the changes you suggested.

@clackary
Copy link
Contributor

clackary commented Dec 5, 2018

@swift-ci test

@clackary clackary merged commit f977900 into apple:master Dec 11, 2018
@clackary
Copy link
Contributor

@onevcat Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants