Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swift-futures #383

Merged
merged 1 commit into from Dec 13, 2019
Merged

Add swift-futures #383

merged 1 commit into from Dec 13, 2019

Conversation

dfunckt
Copy link
Contributor

@dfunckt dfunckt commented Sep 5, 2019

Pull Request Description

Adds swift-futures: https://github.com/dfunckt/swift-futures

Futures is a relatively large library, makes heavy use of value types and generics (which seem to be stressing the compiler quite a bit) and also includes a C target, which overall I think make for a valuable addition to the source compatibility suite.

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 5.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • BSD
    • MIT
    • Apache License, version 2.0
    • Eclipse Public License
    • Mozilla Public License (MPL) 1.1
    • MPL 2.0
    • CDDL
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

@clackary
Copy link
Contributor

@swift-ci test

@clackary clackary merged commit 9cf838e into apple:master Dec 13, 2019
@clackary
Copy link
Contributor

Thanks @dfunckt!

@dfunckt dfunckt deleted the add-swift-futures branch December 14, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants