Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-9306] FunctionParameterSyntax line position incorrect for multi-line function declaration. #441

Closed
swift-ci opened this issue Nov 20, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-9306
Radar None
Original Reporter Leitch (JIRA User)
Type Bug
Status Closed
Resolution Done
Environment

swift-syntax:

0.40200.0

swiftc:

Apple Swift version 4.2.1 (swiftlang-1000.11.42 clang-1000.11.45.1)
Target: x86_64-apple-darwin18.2.0

Xcode:

10.1, Build version 10B61

macOS:

10.14.1

Additional Detail from JIRA
Votes 0
Component/s SwiftSyntax
Labels Bug
Assignee None
Priority Medium

md5: 50ea8a173ef8e58008a21dc3cd1a867b

Issue Description:

Given the following code:

class MyClass {
    func myFunc(param1: String,
                param2: String) {}
}

The line position of the FunctionParameterSyntax for param2 is incorrectly identified as 2, it should be 3. The line for param1 is correctly identified as 2.

@belkadan
Copy link

cc @rintaro

@swift-ci
Copy link
Contributor Author

swift-ci commented Nov 9, 2019

Comment by Ian Leitch (JIRA)

This is fixed in swift-syntax 0.50100.0

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
adevress pushed a commit to adevress/swift-syntax that referenced this issue Jan 14, 2024
Update rules to use the operator-folded syntax tree.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants