WIP: Implement keyword completion based on the syntax tree’s layout #1014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1013 and #1010.
The idea is that we encode enough information as static members of the
Syntax
nodes that we can figure out which tokens are valid choices at a particular position. The nice part is that once we have all that information, the actual code completion is really short and about 130 lines. The results look pretty promising to me with a few that are due to our syntax tree layout (like suggestingas
or->
at the start of an expression because these are valid tokens in an item to aSequenceExpr
and we don’t differentiate the first from the followingSequenceExpr
items. Maybe this also shows areas where we can improve the syntax tree layout.This is implemented in
SwiftParserDiagnsotics
for now, I wanted to move it to IDEUtils once that module is introduced by #999.