[Macros] Introduce member declaration macros. #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
approved these changes
Jan 10, 2023
| return DeclSyntax(expandMembers(of: node)) | ||
| } | ||
|
|
||
| override func visit(_ node: ProtocolDeclSyntax) -> DeclSyntax { |
There was a problem hiding this comment.
What about enums? And... should this use DeclGroupSyntax?
| } | ||
|
|
||
| do { | ||
| try newMembers.append(contentsOf: memberMacro.expansion(of: customAttribute, |
There was a problem hiding this comment.
This worked out really nicely.
|
@swift-ci please test |
hborla
force-pushed
the
member-declaration-macros
branch
from
2d694f9
to
19700f0
Compare
|
@swift-ci please test |
hborla
force-pushed
the
member-declaration-macros
branch
from
19700f0
to
39e8e62
Compare
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial implementation for member declaration macros.
Member declaration macros are represented as custom attributes, and expanding a member macro for a given declaration can produce a set of new members to add to that declaration. For example:
Expanding
@addBackingStorageaddsvar _storagetoS: