[Macros] Introduce CompilerPluginMessageListener #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2023
rintaro
force-pushed
the
macros-message-listener
branch
2 times, most recently
from
3d8a296
to
e240870
Compare
|
apple/swift#69240 |
bnbarham
approved these changes
Oct 18, 2023
Separate message listening logic from 'CompilerPluginMessgeHandler' to 'CompilerPluginMessageListener', so 'CompilerPluginMessageHandler' can be used independently without 'MessageConnection'
rintaro
force-pushed
the
macros-message-listener
branch
from
e240870
to
b27503b
Compare
|
@swift-ci Please test |
ahoppen
approved these changes
Apr 24, 2024
|
apple/swift#69240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate message listening logic from
CompilerPluginMessgeHandlerto newCompilerPluginMessageListener, soCompilerPluginMessageHandlercan be used independently (in the future) withoutMessageConnectionCompilerPluginMessageHandler.handleMessage()now returns a response object instead of sending it to the peer.