Remove public from the extension declaration and add it to each declaration in the extension

[Matejkob]

No description provided.

[ahoppen]

I don’t know with whom I had a conversation about this at some point but I think that private and fileprivate extensions make sense to have. That way if you read private extension, you don’t need to worry about anything leaking out into the rest of the module. public extensions are what I agree can be a source of unintended behavior. Could you maybe:

• Update this PR to remove all public extensions but keep private and fileprivate
• File an issue on https://github.com/apple/swift-format to add a rule to only disallows public extension?

[Matejkob]

I don’t know with whom I had a conversation about this at some point but I think that private and fileprivate extensions make sense to have. That way if you read private extension, you don’t need to worry about anything leaking out into the rest of the module. public extensions are what I agree can be a source of unintended behavior. Could you maybe:

• Update this PR to remove all public extensions but keep private and fileprivate
• File an issue on https://github.com/apple/swift-format to add a rule to only disallows public extension?

I've removed the swift-format rule and moved the public access level attribute manually.

[ahoppen]

Thank you 🙏🏽 Just a few formatting suggestions, otherwise looks good to me 👍🏽

[ahoppen]

Thanks 👍🏽

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[ahoppen]

Could you also create a cherry-pick PR of this to the release/6.0 branch? I think it could make future cherry-picks easier because there are fewer conflicts.