Improve token precedence classifications #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Sep 5, 2022
Comment on lines
+161
to
+162
| DiagnosticSpec(locationMarker: "TEST_1", message: "Unexpected text '@s return' found in function"), | ||
| DiagnosticSpec(locationMarker: "TEST_2", message: "Unexpected text '@unknown return' found in function") |
There was a problem hiding this comment.
return is a fairly strong keyword (IMO), should we really consume it as well?
There was a problem hiding this comment.
That would require more recovery logic in parseStatement. I filed #714 to do this later (after I have merged all my other recovery work).
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #704 this adjusts token precedences a little bit to produce better diagnostics. Previously, we had different logic how we classified weak brackets (like
() and strong brackets (like{). Unify the two concepts and allow consuming weak punctuators (like.or:) while looking for a weak closing bracket and skipping strong punctuators (like;) while looking for a strong closing bracket.