Rebind byte types safely #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
glessard
force-pushed
the
glessard/binding-fixes
branch
from
79e3737
to
f3ef70b
Compare
|
@swift-ci please test |
glessard
force-pushed
the
glessard/binding-fixes
branch
from
f3ef70b
to
64ed41a
Compare
|
@swift-ci please test |
glessard
force-pushed
the
glessard/binding-fixes
branch
from
64ed41a
to
bf1e299
Compare
|
@swift-ci please test |
- this doesn’t use the new memory binding API.
glessard
force-pushed
the
glessard/binding-fixes
branch
from
bf1e299
to
914c782
Compare
|
@swift-ci please test |
lorentey
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates all uses of
assumingMemoryBoundin favor of temporary rebinding, using memory binding API for Swift <5.7. The end result is more memory-safe.