Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak the Windows port #88

Merged
merged 2 commits into from
May 21, 2022
Merged

Unbreak the Windows port #88

merged 2 commits into from
May 21, 2022

Conversation

lorentey
Copy link
Member

Subject says it all.

@lorentey
Copy link
Member Author

@swift-ci test

@compnerd
Copy link
Collaborator

@swift-ci please test

@lorentey
Copy link
Member Author

lorentey commented May 21, 2022 •
edited 

.../swift-system/Tests/SystemTests/FileOperationsTest.swift:85:1: error: expected expression in container literal
#if !os(Windows)
^

My frustration with Swift's dysfunctional #if knows no bounds.

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey changed the title Unbroke the Windows port Unbreak the Windows port May 21, 2022
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey merged commit 82a6704 into main May 21, 2022
@lorentey lorentey deleted the lorentey/unbroke-windows branch May 21, 2022 19:46
@lorentey lorentey mentioned this pull request May 21, 2022
Closed
@simonjbeaumont
Copy link
Contributor

Apologies, since I caused this regression. Do we have any provision for setting up a Windows CI pipeline to catch this in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lorentey @compnerd @simonjbeaumont